Il 24/08/21 06:34, Shawn Guo ha scritto:
It adds the missing a2noc clocks required for QoS registers programming per downstream kernel[1]. Otherwise, qcom_icc_noc_set_qos_priority() call on mas_ufs or mas_usb_hs node will simply result in a hardware hang on SDM660 SoC. [1] https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/sdm660-bus.dtsi?h=LA.UM.8.2.r1-04800-sdm660.0#n43 Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> Tested-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
My Xperia devices are not locking up on any call to qos priority setting, but that's surely because such clocks are left on by the bootloader before booting Linux... and then after booting my USB is up, which is probably why I still don't experience any hang, I guess.
In any case, I do recognize that the a2noc does effectively need these clocks to be on in order to be reachable, as also reported in the downstream dtsi.
Thank you! Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxxx>
