Re: sunxi H5 DTB fix for realtek regression

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 30, 2021 at 05:05:28PM +0200, Andrew Lunn wrote:
[...]
> You need to add a Signed-off-by: See
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
> 

Done.

> Patches need to be in the body of the email, not attachments.
> 

Sent through git-send-email this time (sorry about the hiccup I messed up
the first call).

> You can use scripts/get_maintainers.pl to get a list of people to send
> it to. I would use To: for
> Maxime Ripard <mripard@xxxxxxxxxx> (maintainer:ARM/Allwinner sunXi SoC support)
> Chen-Yu Tsai <wens@xxxxxxxx> (maintainer:ARM/Allwinner sunXi SoC support)
> Jernej Skrabec <jernej.skrabec@xxxxxxxxx> (reviewer:ARM/Allwinner sunXi SoC support)
> 
> and Cc: for the rest.
> 
> > Note: running `git grep 'phy-mode\s*=\s*"rgmii"' arch` shows that it might
> > affect other hardware as well.
> 
> "rgmii" can be correct. So you need to narrow your search.
> 

Yeah I understand that, but I don't know if that can be deduced from the
code only, or if someone needs to look at the hardware specs. As said
initially, I don't have much clue about what's going on here.

> > I don't know how one is supposed to check
> > that, but I would guess at least sun50i-a64-nanopi-a64.dts is affected (a
> > quick internet search shows that it's using a RTL8211E¹)
> 
> This seems reasonable. You could provide a second patch for this.

I'll leave that to the other maintainers; I don't have the hardware to
test and I'm uncomfortable patching something I don't understand.

Regards,

-- 
Clément B.



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux