On Mon, Aug 23, 2021 at 3:06 AM Brad Larson <brad@xxxxxxxxxxx> wrote: > The gpio pins being used for the Elba SoC SPI CS are dedicated to this > function. Are you recommending that the code in > drivers/gpio/gpio-elba-spics.c be integrated into > drivers/spi/spi-dw-mmio.c? That makes most sense does it not? Special purpose pins should be managed by that special purpose hardware driver, DW SPI in this case. The compatible string etc should be enough to determine that we need some extra GPIO control here, possibly specify extra registers for the SPI host etc. The struct spi_master has a special callback .set_cs() and you should make this behave special for your special hardware. In the case of the DW driver it appears that even subdrivers can pass a custom version of this call in struct dw_spi. Yours, Linus Walleij
