On 28/08/2021 18:07, Andrew Lunn wrote: > On Sat, Aug 28, 2021 at 11:27:01AM +0000, Matthew Hagan wrote: >> This patch fixes the following message by adding "mdio-mux" compatible: >> compatible: ['mdio-mux-mmioreg'] is too short > > Err, what? This sounds like a workaround for a tool problem, not a > real fix. > > What is actually wrong with: > > compatible = "mdio-mux-mmioreg"; Yes this does work fine either with or without "mdio-mux". The changes have been made to correspond with those submitted by Rafal Milecki for the BCM5301X platform[1] and to conform with Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml which does state both as required items (and hence not a tool problem). [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@xxxxxxxxx/T/ > > Andrew > Matthew