Hi, Thanks for this patch! my first suggestion is about the patch subject (first line): arm64: dts: meson-sm1-odroid: add Ethernet PHY reset for ODROID-C4/HC4 This makes it match the pattern of the most recent commits there: 45d736ab17b4 arm64: dts: meson-sm1-odroid: add 5v regulator gpio 7881df513680 arm64: dts: meson-sm1-odroid: set tf_io regulator gpio as open source On Thu, Aug 26, 2021 at 5:29 AM Dongjin Kim <tobetter@xxxxxxxxx> wrote: > > This patch is to fix an issue that the ethernet link doesn't come up > when using ip link set down/up: > [ 11.428114] meson8b-dwmac ff3f0000.ethernet eth0: Link is Down > [ 14.428595] meson8b-dwmac ff3f0000.ethernet eth0: PHY [0.0:00] driver [RTL8211F Gigabit Ethernet] (irq=31) > [ 14.428610] meson8b-dwmac ff3f0000.ethernet: Failed to reset the dma > [ 14.428974] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_hw_setup: DMA engine initialization failed > [ 14.711185] meson8b-dwmac ff3f0000.ethernet eth0: stmmac_open: Hw setup failed > > This fix has been referred two commits applied for ODROID-N2 (G12B). > commit 658e4129bb81 ("arm64: dts: meson: g12b: odroid-n2: add the Ethernet PHY reset line") > commit 1c7412530d5d0 ("arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements") I am not 100% sure but I think you can just add two "Fixes: ..." tags here That way this patch is also backported automatically > Signed-off-by: Dongjin Kim <tobetter@xxxxxxxxx> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>