Andreas, Please see my comments inline. On 31.07.2014 18:08, Andreas Färber wrote: > Use the new style of referencing inherited nodes and use symbolic names. > > Suggested-by: Doug Anderson <dianders@xxxxxxxxxxxx> > Signed-off-by: Andreas Färber <afaerber@xxxxxxx> [snip] > - > usb@12110000 { > - samsung,vbus-gpio = <&gpx1 1 0>; > + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>; > }; This is a higher level node being overridden, so it should be specified using references too. > > fixed-rate-clocks { > @@ -287,7 +206,7 @@ > }; > > hdmi { Ditto. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html