On Wed, Aug 25, 2021 at 06:35:17AM +0000, Joel Stanley wrote: > On Tue, 24 Aug 2021 at 19:43, Gabriel L. Somlo <gsomlo@xxxxxxxxx> wrote: > > > > Hi Joel, > > > > Couple of comments below: > > > > On Fri, Aug 20, 2021 at 05:17:26PM +0930, Joel Stanley wrote: > > > > diff --git a/drivers/net/ethernet/litex/Kconfig b/drivers/net/ethernet/litex/Kconfig > > > new file mode 100644 > > > index 000000000000..265dba414b41 > > > --- /dev/null > > > +++ b/drivers/net/ethernet/litex/Kconfig > > > > + > > > +config LITEX_LITEETH > > > + tristate "LiteX Ethernet support" > > > > Mostly cosmetic, but should there be a "depends on LITEX" statement in here? > > No, there's as there is no dependency on the litex soc driver. Which is good, you will get more build coverage that way, it will be built of x86, arm, mips, etc... > > > Maybe also "select MII" and "select PHYLIB"? > > Again, there is no mii or phy code so the driver doesn't need these. Yet. At some point i expect you will need these, but you don't need them now. Andrew
