Am 31.07.2014 19:14, schrieb Andreas Färber:
> Hi,
>
> Am 31.07.2014 19:00, schrieb Vincent Palatin:
>> Always a bit late to the game.
>> One small comment inline.
>>
>> Reviewed-by: Vincent Palatin <vpalatin@xxxxxxxxxxxx>
>
> Thanks,
>
>>
>> On Thu, Jul 31, 2014 at 9:08 AM, Andreas Färber <afaerber@xxxxxxx> wrote:
>>> + usb3_vbus_reg: regulator-usb3 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "P5.0V_USB3CON";
>>> + regulator-min-microvolt = <5000000>;
>>> + regulator-max-microvolt = <5000000>;
>>> + gpio = <&gpe1 0 GPIO_ACTIVE_LOW>;
>>> + enable-active-high;
>>> + };
>>
>> GPE1_0 GPIO is the HSIC hub (SMSC 3503) reset# line (already defined
>> below afaik).
>
> Yes, that was a suggestion you made on v1.
>
>> On this design there is no external USB3 port, so no VBUS reg/load
>> switch for USB3.
>
> Could you be a little clearer? Are you suggesting to drop the gpio
> property?
Nah, doesn't work. Do we need a pinctrl on the usb-hub instead?
Andreas
> I just re-tested that without the regulator node plus the
> vbus-supply below I don't get any USB2 (so maybe rename the regulator?).
>
> Regards,
> Andreas
>
>>> +
>>> + usb@12110000 {
>>> + samsung,vbus-gpio = <&gpx1 1 GPIO_ACTIVE_HIGH>;
>>> + };
>>> +
>>> + usb-hub {
>>> + compatible = "smsc,usb3503a";
>>> + reset-gpios = <&hsic_reset>;
>>> + };
> [...]
>>> +&usbdrd_phy {
>>> + vbus-supply = <&usb3_vbus_reg>;
>>> +};
>>> +
>>> +#include "cros-ec-keyboard.dtsi"
>>> --
>>> 1.9.3
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
