Hi Rob, On Wed, Aug 25, 2021 at 2:21 PM Rob Herring <robh+dt@xxxxxxxxxx> wrote: > On Wed, Aug 25, 2021 at 4:40 AM Geert Uytterhoeven > <geert+renesas@xxxxxxxxx> wrote: > > > > On ia64/allmodconfig: > > > > drivers/of/fdt.c:609:20: error: conflicting types for 'reserve_elfcorehdr'; have 'void(void)' > > 609 | static void __init reserve_elfcorehdr(void) > > | ^~~~~~~~~~~~~~~~~~ > > arch/ia64/include/asm/meminit.h:43:12: note: previous declaration of 'reserve_elfcorehdr' with type 'int(u64 *, u64 *)' {aka 'int(long long unsigned int *, long long unsigned int *)'} > > 43 | extern int reserve_elfcorehdr(u64 *start, u64 *end); > > | ^~~~~~~~~~~~~~~~~~ > > There's no need for the ia64 version to be non-static. Just needs a > forward declaration. > > arch/ia64/include/asm/meminit.h:extern int reserve_elfcorehdr(u64 > *start, u64 *end); > arch/ia64/kernel/setup.c: if (reserve_elfcorehdr(&rsvd_region[n].start, > arch/ia64/kernel/setup.c:int __init reserve_elfcorehdr(u64 *start, u64 *end) I know ;-) https://lore.kernel.org/r/fe236cd73b64abc4abd03dd808cb015c907f4c8c.1629884459.git.geert+renesas@xxxxxxxxx/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds