Hi Brad,
On Mon, Aug 23, 2021 at 6:31 PM Brad Larson <brad@xxxxxxxxxxx> wrote:
> On Mon, Aug 23, 2021 at 12:50 AM Geert Uytterhoeven
> <geert@xxxxxxxxxxxxxx> wrote:
> > On Mon, Aug 23, 2021 at 3:14 AM Brad Larson <brad@xxxxxxxxxxx> wrote:
> > > On Mon, Mar 29, 2021 at 3:40 AM Andy Shevchenko
> [...]
> > > Regarding the above module question and Kconfig definition, since I
> > > first looked at this and reviewed the comments I realized I should be
> > > using builtin. The file gpio/Kconfig is currently this
> > >
> > > config GPIO_ELBA_SPICS
> > > def_bool y
> > > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
> >
> > That means the driver will default to yes by merely enabling
> > COMPILE_TEST, which is a no-go.
> >
> > config GPIO_ELBA_SPICS
> > bool "one-line summary"
> > depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
> > default y if ARCH_PENSANDO_ELBA_SOC
>
> Thanks Geert, changed to this
>
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -241,8 +241,9 @@ config GPIO_EIC_SPRD
> Say yes here to support Spreadtrum EIC device.
>
> config GPIO_ELBA_SPICS
> + bool "Pensando Elba SoC SPI Chip Select as GPIO support"
> + depends on ARCH_PENSANDO_ELBA_SOC
> def_bool y
> - depends on ARCH_PENSANDO_ELBA_SOC || COMPILE_TEST
So we're losing the COMPILE_TEST ability again?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
