On Wed, 30 Jul 2014, Dinh Nguyen wrote:
>
>
>
> On Tue, Jul 29, 2014 at 3:02 PM, Brian Austin <brian.austin@xxxxxxxxxx> wrote:
> This patch adds support for the Cirrus Logic CS35L32 Boosted Amplifier
> I2S Output provides monitor data to the SOC/CODEC for speaker protection algorithms
>
> Signed-off-by: Brian Austin <brian.austin@xxxxxxxxxx>
> ---
> include/dt-bindings/sound/cs35l32.h | 26 ++
> sound/soc/codecs/Kconfig | 5 +
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/cs35l32.c | 670 +++++++++++++++++++++++++++++++++++
> sound/soc/codecs/cs35l32.h | 97 +++++
> 5 files changed, 800 insertions(+)
> create mode 100644 include/dt-bindings/sound/cs35l32.h
> create mode 100644 sound/soc/codecs/cs35l32.c
> create mode 100644 sound/soc/codecs/cs35l32.h
>
> +
> +static int int_clear(struct snd_soc_dapm_widget *w,
> + struct snd_kcontrol *kcontrol, int event)
> +{
> + struct snd_soc_codec *codec = w->codec;
> +
> + if (SND_SOC_DAPM_EVENT_ON(event)) {
> + snd_soc_read(codec, CS35L32_INT_STATUS_1);
> + snd_soc_read(codec, CS35L32_INT_STATUS_2);
> + } else {
> + return 0;
> + }
> + return 0;
>
>
> Can remove one of the "return 0" or why not just a void?
You know, I think I am just going to remove this altogether. It was a
request from Apps and I don't think it is really needed. I'll test without
it and send a v2 with it removed.
Thanks,
Brian
