Hi Rob, On Sun, Aug 15, 2021 at 5:25 PM Rob Herring <robh@xxxxxxxxxx> wrote: > On Wed, Aug 11, 2021 at 10:50:58AM +0200, Geert Uytterhoeven wrote: > > This patch series adds generic support for parsing DT properties related > > to crash dump kernels ("linux,elfcorehdr" and "linux,elfcorehdr" under > > the "/chosen" node), makes use of it on arm32, and performs a few > > cleanups. It is an evolution of the combination of [1] and [2]. > > The DT bits look fine to me. How do you expect this to be merged? I'm > happy to take it if arch maintainers can ack it. I had hoped you could take the series... > > The series consists of 6 parts: > > 1. Patch 1 prepares architecture-specific code (needed for MIPS only) > > to avoid duplicating elf core header reservation later. > > 2. Patch 2 prepares the visibility of variables used to hold > > information retrieved from the DT properties. > > 3. Patches 3-5 add support to the FDT core for handling the > > properties. > > This can co-exist safely with architecture-specific handling, until > > the latter has been removed. > > Looks like patch 5 doesn't have any dependencies with the series? Indeed. So you can take it independently. > > 4. Patch 6 removes the non-standard handling of "linux,elfcorehdr" on > > riscv. > > I thought this should be applied for 5.14? Me too, but unfortunately that hasn't happened yet... > > 5. Patches 7-8 convert arm64 to use the generic handling instead of > > its own implementation. > > 6. Patch 9 adds support for kdump properties to arm32. > > The corresponding patch for kexec-tools is "[PATCH] arm: kdump: Add > > DT properties to crash dump kernel's DTB"[3], which is still valid. > > This one can be applied on its own, right? While that wouldn't break anything (i.e. no regression), it still wouldn't work if the DT properties are present, and the now-legacy "mem=" kernel command line parameter is not. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds