Hi Pratyush,
Thank you for the patch.
On Sat, Aug 21, 2021 at 12:33:46AM +0530, Pratyush Yadav wrote:
> The DPHY is treated to be in Tx mode by default. Add a new compatible
> for Rx mode DPHYs.
>
> Signed-off-by: Pratyush Yadav <p.yadav@xxxxxx>
>
> ---
>
> Changes in v4:
> - New in v4.
>
> Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> index d5a5e1f0b671..48b6a841152e 100644
> --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml
> @@ -11,8 +11,9 @@ maintainers:
>
> properties:
> compatible:
> - items:
> + oneOf:
> - const: cdns,dphy
> + - const: cdns,dphy-rx
It's customary to use an enum instead:
compatibles:
enum:
- cdns,dphy
- cdns,dphy-tx
I don't know if Rob has a preference for consistency (or for any other
reason). In either case,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
>
> reg:
> maxItems: 1
--
Regards,
Laurent Pinchart
