Am Freitag, 20. August 2021, 23:16:23 CEST schrieb Brian Norris: > On Fri, Aug 20, 2021 at 2:05 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > I guess one minor nit (now that I look back on the veyron patch where > > I mentioned it explicitly in the commit message) is that on the veyron > > ones we sorted this down at the bottom with the other pinctrl stuff > > instead of sorting it alphabetically with everything else. I'll let > > Heiko say which he likes better. > > Huh, didn't notice that semi-convention. I can sort it however Heiko prefers. Hmm, I wouldn't call it a semi-convention ... it was more an idea of getting all the longer pages of "stuff" out of the way. I don't think I have a real hard preference for the gpioX nodes and I guess in the long run it might be helpful to try to limit the number of "semi-conventions" . I still like "pinctrl at the bottom", but I guess it might be easier to with alphabetical for nodes with the rest :-) . Heiko > > I also notice for veyron that we had a second "ABI" exception for the > > recovery mode pin, but I believe that goes through a different > > mechanism now so we're good there. > > I believe the recovery mode pin is dropped from recent designs (don't > quote me in general on that), and there's a different mechanism used > just to get the at-boot-time "recovery mode" state directly from the > firmware. > > > Even though I didn't do a line-by-line review, I'll still give: > > > > Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx> > > > > ...though it's possible an "Acked-by" would be more in the spirit of > > that? Not sure... > > Thanks! > > Brian >
