On 20/08/2021 11:31, Jisheng Zhang wrote: > Add a basic support for AS370-RDK board based on the AS370 SoC. We can > get a basic shell on the uart console now. > > Signed-off-by: Jisheng Zhang <Jisheng.Zhang@xxxxxxxxxxxxx> > --- > Hi Arnd, > > If it's too late, I will add it in a PR for 5.16 in next development window. > > Thanks > > arch/arm64/boot/dts/synaptics/Makefile | 1 + > arch/arm64/boot/dts/synaptics/as370-rdk.dts | 29 +++++++++++++++++++++ > 2 files changed, 30 insertions(+) > create mode 100644 arch/arm64/boot/dts/synaptics/as370-rdk.dts > > diff --git a/arch/arm64/boot/dts/synaptics/Makefile b/arch/arm64/boot/dts/synaptics/Makefile > index de71ddda6835..c1c4f6c040b3 100644 > --- a/arch/arm64/boot/dts/synaptics/Makefile > +++ b/arch/arm64/boot/dts/synaptics/Makefile > @@ -1,4 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > # Berlin SoC Family > +dtb-$(CONFIG_ARCH_BERLIN) += as370-rdk.dtb > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-dmp.dtb > dtb-$(CONFIG_ARCH_BERLIN) += berlin4ct-stb.dtb > diff --git a/arch/arm64/boot/dts/synaptics/as370-rdk.dts b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > new file mode 100644 > index 000000000000..6f5c37c98be6 > --- /dev/null > +++ b/arch/arm64/boot/dts/synaptics/as370-rdk.dts > @@ -0,0 +1,29 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright (C) 2018-2021 Synaptics Incorporated > + * > + * Author: Jisheng Zhang <jszhang@xxxxxxxxxx> > + */ > + > +/dts-v1/; > + > +#include "as370.dtsi" > + > +/ { > + model = "Synaptics AS370 RDK"; > + compatible = "syna,as370-rdk", "syna,as370"; There is no such binding. You need to update the bindings file (first patch in the series). Best regards, Krzysztof