On Wed, Aug 18, 2021 at 1:22 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Aug 10, 2021 at 12:55:29PM +0530, Shubhrajyoti Datta wrote: > > Add the devicetree binding for the xilinx clocking wizard. > > > > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> > > --- > > v6: > > Fix a yaml warning > > v7: > > Add vendor prefix speed-grade > > v8: > > Fix the warnings > > v10: > > Add nr-outputs > > v11: > > add the compatibles for various versions > > rename nr-outputs to xlnx,nr-outputs > > v12: > > No change > > > > .../bindings/clock/xlnx,clocking-wizard.yaml | 77 +++++++++++++++++++ > > 1 file changed, 77 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > > > diff --git a/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > new file mode 100644 > > index 000000000000..74a121988e92 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml > > @@ -0,0 +1,77 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: "http://devicetree.org/schemas/clock/xlnx,clocking-wizard.yaml#" > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > > + > > +title: Xilinx clocking wizard > > + > > +maintainers: > > + - Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx> > > + > > +description: > > + The clocking wizard is a soft ip clocking block of Xilinx versal. It > > + reads required input clock frequencies from the devicetree and acts as clock > > + clock output. > > + > > +properties: > > + compatible: > > + enum: > > + - xlnx,clocking-wizard > > What version is this one? This is kept for backward compatibility the current driver expects this string > > > + - xlnx,clocking-wizard-v5-2 # version 5.2 > > + - xlnx,clocking-wizard-v6-0 # version 6.0 > > The comment is pretty pointless. And periods are allowed in compatible > strings, so just do '-v5.2'. sure will do. > > > + > > + > > + reg: > > + maxItems: 1 > > +