On 10/08/2021 10:08, Yong Wu wrote: > This patchset mainly adds SMI support for mt8195. > > Comparing with the previous version, add two new functions: > a) add smi sub common > b) add initial setting for smi-common and smi-larb. > > Change note: > v3:1) In the dt-binding: > a. Change mediatek,smi type from phandle-array to phandle from Rob. > b. Add a new bool property (mediatek,smi_sub_common) > to indicate if this is smi-sub-common. > 2) Change the clock using bulk parting. > keep the smi-common's has_gals flag. more strict. > 3) More comment about larb initial setting. > 4) Add a maintain patch The patchset looks good to me but I saw now comments from Rob, so I expect a resend. Therefore there is also time for additional review - maybe continued by Ikjoon Jang? If you sent a v4 with fixes rather soon and get ack from Rob, I could still try to get it into next merge window. After this weekend I won't be taking patches for this cycle and it will wait for the merge window to finish. Best regards, Krzysztof