Hi,
On 8/16/21 10:27 AM, Krzysztof Kozlowski wrote:
> Reading status register can fail in the interrupt handler. In such
> case, the regmap_read() will not store anything useful under passed
> 'val' variable and random stack value will be used to determine type of
> interrupt.
>
> Handle the regmap_read() failure to avoid handling interrupt type and
> triggering changed power supply event based on random stack value.
>
> Fixes: 39e7213edc4f ("max17042_battery: Support regmap to access device's registers")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
Thanks, the entire series looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
For the series.
Regards,
Hans
> ---
> drivers/power/supply/max17042_battery.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/max17042_battery.c b/drivers/power/supply/max17042_battery.c
> index ce2041b30a06..858ae97600d4 100644
> --- a/drivers/power/supply/max17042_battery.c
> +++ b/drivers/power/supply/max17042_battery.c
> @@ -869,8 +869,12 @@ static irqreturn_t max17042_thread_handler(int id, void *dev)
> {
> struct max17042_chip *chip = dev;
> u32 val;
> + int ret;
> +
> + ret = regmap_read(chip->regmap, MAX17042_STATUS, &val);
> + if (ret)
> + return IRQ_HANDLED;
>
> - regmap_read(chip->regmap, MAX17042_STATUS, &val);
> if ((val & STATUS_INTR_SOCMIN_BIT) ||
> (val & STATUS_INTR_SOCMAX_BIT)) {
> dev_info(&chip->client->dev, "SOC threshold INTR\n");
>
