Hi Sergei,
Thanks for the feedback.
> Subject: Re: [PATCH v6 3/3] arm64: dts: renesas: r9a07g044: Add USB2.0
> device support
>
> On 8/12/21 6:18 PM, Biju Das wrote:
>
> > Add USB2.0 device support to RZ/G2L SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> [...]
> > diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > index de78c921af22..2f313c2a81c7 100644
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -391,6 +391,25 @@
> > power-domains = <&cpg>;
> > status = "disabled";
> > };
> > +
> > + hsusb: usb@11c60000 {
> > + compatible = "renesas,usbhs-r9a07g044",
> > + "renesas,rza2-usbhs";
> > + reg = <0 0x11c60000 0 0x10000>;
> > + interrupts = <GIC_SPI 100 IRQ_TYPE_EDGE_RISING>,
> > + <GIC_SPI 101 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>,
> > + <GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>;
>
> Don't we need to specify "interrupt-names" when there a more than 1
> interrupts?
This dtsi changes, as per binding documentation [1]. As you see, "interrupt-names" is optional.
[1] :- https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/devicetree/bindings/usb/renesas,usbhs.yaml?h=next-20210812
>
> > + clocks = <&cpg CPG_MOD R9A07G044_USB_PCLK>,
> > + <&cpg CPG_MOD R9A07G044_USB_U2P_EXR_CPUCLK>;
>
> And "clock-names" too?
Same here. It is optional.
>
> > + resets = <&phyrst 0>,
> > + <&cpg R9A07G044_USB_U2P_EXL_SYSRST>;
>
> And "reset-names"?
Same here. It is optional.
Regards,
Biju
>
> [...]
>
> MBR, Sergei
