Re: [RFC PATCH v2 1/2] dt-bindings: net: New binding for mctp-i2c-generic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 11 Aug 2021 11:43:44 +0800, Matt Johnston wrote:
> An I2C bus with attached MCTP peripherals can be configured to be
> accessible to the host system, using a specified I2C address.
> 
> This mctp-i2c-generic binding can attach to existing I2C bus
> that supports slave functionality.
> 
> For a fictional hardware I2C controller:
> 
>     /* for I2C_OWN_SLAVE_ADDRESS */
>     #include <dt-bindings/i2c/i2c.h>
> 
>     /* root-level i2c controller */
>     i2c {
>         compatible = "vendor,example-i2c-controller";
>         reg = <...>
>         #address-cells = <1>;
>         #size-cells = <0>;
> 
>         mctp@50 {
>             compatible = "mctp-i2c";
>             reg = <(0x50 | I2C_OWN_SLAVE_ADDRESS)>;
>         };
>     };
> 
> Signed-off-by: Matt Johnston <matt@xxxxxxxxxxxxxxxxxxxx>
> ---
>  .../bindings/net/mctp-i2c-generic.yaml        | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/mctp-i2c-generic.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/mctp-i2c-generic.example.dt.yaml:0:0: /example-0/i2c/mctp@50: failed to match any schema with compatible: ['mctp-i2c']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1515565

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux