Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v5 4/6] arm64: dts: renesas: r9a07g044: Add USB2.0 phy
> and host support
>
> Hi Biju,
>
> On Tue, Jul 27, 2021 at 8:55 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Add USB2.0 phy and host support to SoC DT.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -200,6 +200,100 @@
> > <0x0 0x11940000 0 0x60000>;
> > interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_LOW>;
> > };
> > +
> > + phyrst: usbphy-ctrl@11c40000 {
> > + compatible = "renesas,r9a07g044-usbphy-ctrl",
> > + "renesas,rzg2l-usbphy-ctrl";
> > + reg = <0 0x11c40000 0 0x10000>;
> > + clocks = <&cpg CPG_MOD R9A07G044_USB_PCLK>;
> > + resets = <&cpg R9A07G044_USB_PRESETN>;
> > + power-domains = <&cpg>;
> > + #reset-cells = <1>;
>
> Should there be a status = "disabled"?
OK, will add it in SoC dtsi, since all RZ/G2L based boards have USB support.
In future, if there is a requirement for handling of permanently unused pin
as mentioned in section "34.4.2. Handling of permanently unused pin"
then we need to enable this driver in SoC dtsi. with dt-binding and driver probe
changes for handling the same.
Cheers,
Biju
>
> > + };
>
> The rest looks good to me, so with the above clarified:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
