Hi Piyush, thanks for your patch! Can you explain one thing to me: since this is now a GPIO driver that means "General Purpos Input/Output", then these bits are accessed like this: On Thu, Aug 5, 2021 at 7:43 PM Piyush Mehta <piyush.mehta@xxxxxxxxxx> wrote: > + ret = zynqmp_pm_bootmode_read(&bootpin_val); This does not look very general purpose. These seem to be all about boot mode, right? So can you explain why this should be a GPIO driver at all? I understand it is sometimes convenient to describe stuff as GPIO even if it is not (for example to get a convenient userspace interface) but as maintainers we really need to make sure that the subsystem is not being abused for things not GPIO. Yours, Linus Walleij
