RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property

[Joakim Zhang <qiangqing.zhang@xxxxxxx>]

> -----Original Message-----
> From: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> Sent: 2021年8月11日 16:05
> To: Jan Lübbe <jlu@xxxxxxxxxxxxxx>; srinivas.kandagatla@xxxxxxxxxx;
> robh+dt@xxxxxxxxxx; shawnguo@xxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> kernel@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> property
> 
> 
> > -----Original Message-----
> > From: Jan Lübbe <jlu@xxxxxxxxxxxxxx>
> > Sent: 2021年8月10日 23:14
> > To: Joakim Zhang <qiangqing.zhang@xxxxxxx>;
> > srinivas.kandagatla@xxxxxxxxxx; robh+dt@xxxxxxxxxx;
> > shawnguo@xxxxxxxxxx
> > Cc: devicetree@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> > kernel@xxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> > property
> >
> > On Tue, 2021-08-10 at 15:35 +0800, Joakim Zhang wrote:
> > > Introduce "reverse-data" property for nvmem provider to reverse buffer.
> > >
> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > index b8dc3d2b6e92..bc745083fc64 100644
> > > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > @@ -61,6 +61,11 @@ patternProperties:
> > >                description:
> > >                  Size in bit within the address range specified by reg.
> > >
> > > +      reverse-data:
> > > +        $ref: /schemas/types.yaml#/definitions/flag
> > > +        description:
> > > +          Reverse the data that read from the storage device.
> >
> > I'd prefer if it was more explicit that the *bytes* will be reversed.
> > Otherwise a reader might think that this is reversing on the *bit* level.
> 
> Make sense, how about 'reverse-byte-order'?

Sorry, 'reverse-bytes-order'.

Best Regards,
Joakim Zhang
> Best Regards,
> Joakim Zhang
> > Jan
> >
> > > +
> > >      required:
> > >        - reg
> > >
> >
> > --
> > Pengutronix e.K.                           |
> > |
> > Steuerwalder Str. 21                       |
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p
> > e
> >
> ngutronix.de%2F&amp;data=04%7C01%7Cqiangqing.zhang%40nxp.com%7C79
> >
> 3a60188540455919b608d95c118878%7C686ea1d3bc2b4c6fa92cd99c5c30163
> >
> 5%7C0%7C0%7C637642052637994749%7CUnknown%7CTWFpbGZsb3d8eyJWI
> >
> joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1
> >
> 000&amp;sdata=S27O8AV8lRvGxyEutJl6Uh4AjbArD%2BkvQl%2FI05ZU1P8%3D
> > &amp;reserved=0  |
> > 31137 Hildesheim, Germany                  | Phone:
> +49-5121-206917-0
> > |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:
> > +49-5121-206917-5555 |