Hi Guenter, > -----Original Message----- > From: Guenter Roeck <groeck7@xxxxxxxxx> On Behalf Of Guenter Roeck > Sent: 2021年8月9日 9:41 > To: Joakim Zhang <qiangqing.zhang@xxxxxxx> > Cc: davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; robh+dt@xxxxxxxxxx; > andrew@xxxxxxx; netdev@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > linux-kernel@xxxxxxxxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx> > Subject: Re: [PATCH V1 4/5] net: fec: add eee mode tx lpi support > > On Fri, Jul 09, 2021 at 03:53:54PM +0800, Joakim Zhang wrote: > > From: Fugang Duan <fugang.duan@xxxxxxx> > > > > The i.MX8MQ ENET version support IEEE802.3az eee mode, add eee mode tx > > lpi enable to support ethtool interface. > > > > usage: > > 1. set sleep and wake timer to 5ms: > > ethtool --set-eee eth0 eee on tx-lpi on tx-timer 5000 2. check the eee > > mode: > > ~# ethtool --show-eee eth0 > > EEE Settings for eth0: > > EEE status: enabled - active > > Tx LPI: 5000 (us) > > Supported EEE link modes: 100baseT/Full > > 1000baseT/Full > > Advertised EEE link modes: 100baseT/Full > > 1000baseT/Full > > Link partner advertised EEE link modes: 100baseT/Full > > > > Note: For realtime case and IEEE1588 ptp case, it should disable EEE > > mode. > > > > Signed-off-by: Fugang Duan <fugang.duan@xxxxxxx> > > Signed-off-by: Joakim Zhang <qiangqing.zhang@xxxxxxx> > > This patch results in: > > drivers/net/ethernet/freescale/fec_main.c: In function > 'fec_enet_eee_mode_set': > drivers/net/ethernet/freescale/fec_main.c:2801:40: error: 'FEC_LPI_SLEEP' > undeclared > drivers/net/ethernet/freescale/fec_main.c:2802:39: error: 'FEC_LPI_WAKE' > undeclared > > when building m68k:m5272c3_defconfig. I just sent to patch to fix this build issue, sorry for this inconvenience. Best Regards, Joakim Zhang > Guenter
