On Thu, Aug 5, 2021 at 6:26 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > On Thu, 05 Aug 2021, Alistair Francis wrote: > > > On Wed, Aug 4, 2021 at 10:43 PM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > > > > On Tue, 03 Aug 2021, Alistair Francis wrote: > > > > > > > Enable the silergy,sy7636a and silergy,sy7636a-regulator on the > > > > reMarkable2. > > > > > > > > Signed-off-by: Alistair Francis <alistair@xxxxxxxxxxxxx> > > > > --- > > > > arch/arm/boot/dts/imx7d-remarkable2.dts | 42 +++++++++++++++++++++++++ > > > > 1 file changed, 42 insertions(+) > > > > > > I don't see the DT documentation for this device. > > > > Which device? > > > > The imx7d-remarkable2 is in current master and there is a single line > > at `Documentation/devicetree/bindings/arm/fsl.yaml` > > > > The silergy,sy7636a-regulator is also already in master, but it isn't > > I think this is currently in -next. Sorry, I thought it was in mainline at this point. > > It won't land in Mainline (what I believe you're calling "master") > until the next merge window, which is about a month. Ah, yep. I meant to say mainline. Every project has different terminology. > > > exposed to device tree and the compatible string shouldn't be included > > in this patch. I'll fix that. > > Okay, this is essentially what I was getting at. > > The node should really be documented and Acked by the DT guys. Should the regulator have it's own DT binding documentation? From what I could tell just including it in mfd bindings was enough. > > .. > > Anyway, I have a new toy for you to play with. > > I'll Cc you on the patch. I'll keep a look out! Alistair > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog
