On Wed, 28 Jul 2021 at 23:38, <rentao.bupt@xxxxxxxxx> wrote: > > From: Tao Ren <rentao.bupt@xxxxxxxxx> > > Add initial version of device tree for Facebook Fuji (AST2600) BMC. I like to read what kind of platform the BMC is going into if you can add that detail, but it's not essential. > +&spi1 { > + status = "okay"; > + > + /* > + * Customize spi1 flash memory size to 32MB (maximum flash size on > + * the bus) to save vmalloc space. > + */ > + reg = < 0x1e630000 0xc4 > + 0x30000000 0x2000000 >; Which driver supports this? It would be great to see Facebook work to get the SPI NOR driver for the ast2600 merged to mainline. I doubt the IBM team will get to this, as we are using eMMC instead. > + > + flash@0 { > + status = "okay"; > + m25p,fast-read; > + label = "spi1.0"; > + spi-max-frequency = <5000000>; > + > + partitions { > + compatible = "fixed-partitions"; > + #address-cells = <1>; > + #size-cells = <1>; > + > + flash1@0 { > + reg = <0x0 0x2000000>; > + label = "system-flash"; > + }; > + }; > + }; > +}; > +&ehci1 { > + status = "okay"; > +}; Have you verified that USB works with mainline? I've had reports of it working on 5.8 but it seems to have regressed as of v5.10. > +&mdio1 { > + status = "okay"; > + > + ethphy3: ethernet-phy@13 { > + compatible = "ethernet-phy-ieee802.3-c22"; > + reg = <0x0d>; > + }; > +}; > + > +&mac3 { > + phy-handle = <ðphy3>; status = okay? You should specify the pinmux too I think, even if the default happens to work, so that other devices cannot claim the pins. Cheers, Joel