Re: [PATCH v4] dt-bindings: riscv: add starfive jh7100 bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 04 Aug 2021 13:54:16 PDT (-0700), atishp@xxxxxxxxxxxxxx wrote:
On Wed, Aug 4, 2021 at 1:33 PM Palmer Dabbelt <palmer@xxxxxxxxxxx> wrote:

On Thu, 15 Jul 2021 19:17:23 PDT (-0700), bmeng.cn@xxxxxxxxx wrote:
> On Tue, Jul 13, 2021 at 2:34 PM Drew Fustini <drew@xxxxxxxxxxxxxxx> wrote:
>>
>> Add DT binding documentation for the StarFive JH7100 Soc [1] and the
>> BeagleV Starlight JH7100 board [2].
>>
>> [1] https://github.com/starfive-tech/beaglev_doc
>> [2] https://github.com/beagleboard/beaglev-starlight
>>
>> Signed-off-by: Drew Fustini <drew@xxxxxxxxxxxxxxx>
>> ---
>> v4 changes:
>> - removed JH7100 SoC revision number after discussion with Geert
>>
>> v3 changes:
>> - added revision number for the board and soc after question from Palmer
>>
>> v2 changes:
>> - removed "items:" entry that only had "const: starfive,jh7100"
>> - correct typo in Description:
>>
>> Results of running checks:
>>   $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dt_binding_check \
>>     DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
>>     CHKDT   Documentation/devicetree/bindings/processed-schema-examples.json
>>     DTEX    Documentation/devicetree/bindings/riscv/starfive.example.dts
>>     SCHEMA  Documentation/devicetree/bindings/processed-schema-examples.json
>>     DTC     Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
>>     CHECK   Documentation/devicetree/bindings/riscv/starfive.example.dt.yaml
>>   $ make -j8 ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- dtbs_check \
>>     DT_SCHEMA_FILES=Documentation/devicetree/bindings/riscv/starfive.yaml
>>     SYNC    include/config/auto.conf.cmd
>>     UPD     include/config/kernel.release
>>     SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>>     DTC     arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dtb
>>     DTC     arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml
>>     DTC     arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
>>     DTC     arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dt.yaml
>>     CHECK   arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dt.yaml
>>     CHECK   arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dt.yaml
>>     CHECK   arch/riscv/boot/dts/starfive/jh7100-beaglev-starlight.dt.yaml
>>
>> The dts file is from vendor repo and is being cleaned up right now in
>> preperation for submitting to the mailing list:
>> https://github.com/starfive-tech/linux/tree/beaglev/arch/riscv/boot/dts/starfive
>>
>>  .../devicetree/bindings/riscv/starfive.yaml   | 27 +++++++++++++++++++
>>  1 file changed, 27 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/riscv/starfive.yaml
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@xxxxxxxxx>

Thanks.  This is on for-next, as Rob suggested taking it via the RISC-V
tree.

Given that beagleV starlight mass production is cancelled [1], are we
still upstreaming the support for this ?

I'm not sure, but I wasn't quite sure where to have that discussion. I figured that the boards exist so there's no reason to shoot this down, given that it's just the vendor DT list. At a bare minimum there's out of tree support for this, so having the DT strings defined seems sane as that's a defacto interface with bootloaders.

Maybe this is more of a question for Drew: I think we were all OK working through the issues with the first-run chip when there was going to be a lot of them, but with such a small number produced I'm not sure if there's going to be enough interested to take on all that effort. I'm not quite sure where we stand on support for this: at some point there were some ideas floating around as to a way to support it without major software changes (allocating into the non-caching regions). If that pans out then I'm fine handling this, at least from the RISC-V side, but if we're going to have to go through all the ISA/SBI stuff then it's probably not worth it. Also not sure if there are a bunch of starfive-specific drivers that would be needed to make this boot, in which case it's probably best to wait for whatever comes next.


[1] https://www.cnx-software.com/2021/07/31/beaglev-starlight-sbc-wont-be-mass-manufactured-redesigned-beaglev-risc-v-sbc-expected-in-q1-2022/
_______________________________________________
linux-riscv mailing list
linux-riscv@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-riscv



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux