On Tue, Jul 29, 2014 at 04:20:20AM +0200, Sebastian Reichel wrote: > Hi, > > On Mon, Jul 28, 2014 at 04:16:01PM -0500, Felipe Balbi wrote: > > this will let us drop .handle_irq and .init_irq fields > > from our generic machine_descs. > > > > Signed-off-by: Felipe Balbi <balbi@xxxxxx> > > --- > > arch/arm/mach-omap2/irq.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-omap2/irq.c b/arch/arm/mach-omap2/irq.c > > index e6997c5..e452411 100644 > > --- a/arch/arm/mach-omap2/irq.c > > +++ b/arch/arm/mach-omap2/irq.c > > @@ -314,6 +314,8 @@ static int __init intc_of_init(struct device_node *node, > > > > omap_init_irq(res.start, nr_irq, of_node_get(node)); > > > > + set_handle_irq(omap2_intc_handle_irq); > > + > > return 0; > > } > > > > if you respin the patchset you may want to call omap_intc_handle_irq > directly. It makes the review of the patchset less confusing. > > (I was wondering why omap3 can call omap2_intc_handle_irq until I > noticed, that your previous changes made both functions simple > wrapper functions for omap_intc_handle_irq) this is done later for a reason. At this point, omap_intc_handle_irq() still misses proper annotations for asmlinkage and __exception_irq_entry. -- balbi
Attachment:
signature.asc
Description: Digital signature
