On Wed, Jul 28, 2021 at 11:14 AM Johan Jonker <jbx6244@xxxxxxxxx> wrote: > > Hi Peter, > > Some comments. Have a look if it's useful. > > On 7/28/21 2:25 PM, Peter Geis wrote: > > The rk3568 usb2phy node is a standalone node with a single muxed > > interrupt. > > Add documentation for it to phy-rockchip-inno-usb2. > > > > Signed-off-by: Peter Geis <pgwipeout@xxxxxxxxx> > > --- > > .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > > index 5bebd86bf8b6..f16fea5cad1c 100644 > > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml > > @@ -18,6 +18,7 @@ properties: > > - rockchip,rk3328-usb2phy > > - rockchip,rk3366-usb2phy > > - rockchip,rk3399-usb2phy > > + - rockchip,rk3568-usb2phy > > - rockchip,rv1108-usb2phy > > > > reg: > > @@ -50,6 +51,9 @@ properties: > > description: > > Phandle to the extcon device providing the cable state for the otg phy. > > > > > + interrupts: > > > + description: Muxed interrupt for both ports > > My spelling checker suggest: Mixed. Don't know what's correct... It is muxed, all interrupts come over the single line. > > > + > > For rk3568 only. > Could you test/use something like this? > > if: > properties: > compatible: > contains: > const: rockchip,rk3568-usb2phy > > then: > properties: > interrupts: > maxItems: 1 > > required: > - interrupts > > > rockchip,usbgrf: > > $ref: /schemas/types.yaml#/definitions/phandle > > description: > > @@ -78,8 +82,6 @@ properties: > > > > > required: > > - "#phy-cells" > > - - interrupts > > - - interrupt-names > > These are still required for other Rockchip SoCs. > Could you test/use something like this? > > if: > properties: > compatible: > contains: > const: rockchip,rk3568-usb2phy > > else: > required: > - interrupts > - interrupt-names This is all sane to me, I'll check to ensure it works. > > > > > otg-port: > > type: object > > @@ -109,8 +111,6 @@ properties: > > > > > required: > > - "#phy-cells" > > - - interrupts > > - - interrupt-names > > dito > > > > > required: > > - compatible > > Thank you for the feedback!
