On Sun, Jul 25, 2021 at 6:01 PM Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > > On Sat, Jul 24, 2021 at 11:19:21AM -0700, Tim Harvey wrote: > > On Tue, Jun 1, 2021 at 10:49 AM Tim Harvey <tharvey@xxxxxxxxxxxxx> wrote: > > > > > > Fix various MP5416 PMIC configurations: > > > - Update regulator names per dt-bindings > > > - ensure values fit among valid register values > > > - add required regulator-max-microamp property > > > - add regulator-always-on prop > > > > > > Signed-off-by: Tim Harvey <tharvey@xxxxxxxxxxxxx> > > > --- > > > .../dts/freescale/imx8mm-venice-gw700x.dtsi | 56 ++++++++++++------- > > > 1 file changed, 37 insertions(+), 19 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > > > index 512b76cd7c3b..f4eb827baed7 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw700x.dtsi > > > @@ -283,65 +283,83 @@ > > > reg = <0x69>; > > > > > > regulators { > > > + /* vdd_0p95: DRAM/GPU/VPU */ > > > buck1 { > > > - regulator-name = "vdd_0p95"; > > > - regulator-min-microvolt = <805000>; > > > + regulator-name = "buck1"; > > > + regulator-min-microvolt = <800000>; > > > regulator-max-microvolt = <1000000>; > > > - regulator-max-microamp = <2500000>; > > > + regulator-min-microamp = <3800000>; > > > + regulator-max-microamp = <6800000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_soc */ > > > buck2 { > > > - regulator-name = "vdd_soc"; > > > - regulator-min-microvolt = <805000>; > > > + regulator-name = "buck2"; > > > + regulator-min-microvolt = <800000>; > > > regulator-max-microvolt = <900000>; > > > - regulator-max-microamp = <1000000>; > > > + regulator-min-microamp = <2200000>; > > > + regulator-max-microamp = <5200000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_arm */ > > > buck3_reg: buck3 { > > > - regulator-name = "vdd_arm"; > > > - regulator-min-microvolt = <805000>; > > > + regulator-name = "buck3"; > > > + regulator-min-microvolt = <800000>; > > > regulator-max-microvolt = <1000000>; > > > - regulator-max-microamp = <2200000>; > > > - regulator-boot-on; > > > + regulator-min-microamp = <3800000>; > > > + regulator-max-microamp = <6800000>; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_1p8 */ > > > buck4 { > > > - regulator-name = "vdd_1p8"; > > > + regulator-name = "buck4"; > > > regulator-min-microvolt = <1800000>; > > > regulator-max-microvolt = <1800000>; > > > - regulator-max-microamp = <500000>; > > > + regulator-min-microamp = <2200000>; > > > + regulator-max-microamp = <5200000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* nvcc_snvs_1p8 */ > > > ldo1 { > > > - regulator-name = "nvcc_snvs_1p8"; > > > + regulator-name = "ldo1"; > > > regulator-min-microvolt = <1800000>; > > > regulator-max-microvolt = <1800000>; > > > - regulator-max-microamp = <300000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_snvs_0p8 */ > > > ldo2 { > > > - regulator-name = "vdd_snvs_0p8"; > > > + regulator-name = "ldo2"; > > > regulator-min-microvolt = <800000>; > > > regulator-max-microvolt = <800000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_0p9 */ > > > ldo3 { > > > - regulator-name = "vdd_0p95"; > > > - regulator-min-microvolt = <800000>; > > > - regulator-max-microvolt = <800000>; > > > + regulator-name = "ldo3"; > > > + regulator-min-microvolt = <900000>; > > > + regulator-max-microvolt = <900000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > > > > + /* vdd_1p8 */ > > > ldo4 { > > > - regulator-name = "vdd_1p8"; > > > + regulator-name = "ldo4"; > > > regulator-min-microvolt = <1800000>; > > > regulator-max-microvolt = <1800000>; > > > regulator-boot-on; > > > + regulator-always-on; > > > }; > > > }; > > > }; > > > -- > > > 2.17.1 > > > > > > > Shawn, > > > > Is there anything you want changed here? > > Tim, > > Could you resend the series? For some reason, I cannot find the > original posting in my mailbox. > > Shawn Sure... probably better anyway as I was asking you to drop one of them from the series. Tim