On Sun, Jul 25, 2021 at 12:27 PM Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> wrote: > > On Thu 22 Jul 05:01 CDT 2021, Baruch Siach wrote: > > > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > > > Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx> > > --- > > v6: > > > > Device node is child of TCSR; remove phandle (Rob Herring) > > > > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König) > > > > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn > > Andersson, Kathiravan T) > > > > v4: Update the binding example node as well (Rob Herring's bot) > > > > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) > > > > v2: Make #pwm-cells const (Rob Herring) > > --- > > .../devicetree/bindings/pwm/ipq-pwm.yaml | 69 +++++++++++++++++++ > > 1 file changed, 69 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > new file mode 100644 > > index 000000000000..ee2bb03a1223 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > @@ -0,0 +1,69 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ6018 PWM controller > > + > > +maintainers: > > + - Baruch Siach <baruch@xxxxxxxxxx> > > + > > +properties: > > + "#pwm-cells": > > + const: 2 > > + > > + compatible: > > + const: qcom,ipq6018-pwm > > + > > + offset: > > + description: | > > '|' maintains the formatting of the text, you don't need that. > > > + Offset of PWM register in the TCSR block. > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + const: core > > With a single clock, it's nice to skip the -names. > > > + > > + assigned-clocks: > > + maxItems: 1 > > + > > + assigned-clock-rates: > > + maxItems: 1 > > These (assigned-*) are generic properties that may be used on a lot of > nodes, should they really be part of the individual binding, Rob? They are allowed on any node with 'clocks', so you don't need them. However, if you know there's 1 entry only, then I'd keep that. Or was 'maxItems: 1' just copied because I see that alot. Rob
