Hi Andy, Thank you for the review. On Mon, Jul 26, 2021 at 2:35 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Mon, Jul 26, 2021 at 4:25 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Wed, Jul 21, 2021 at 9:16 PM Lad Prabhakar > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > ... > > > > +#define RZG2L_GPIO_PORT_GET_PINCNT(x) (((x) >> 28) & 0x7) > > > +#define RZG2L_GPIO_PORT_GET_INDEX(x) ((((x) & GENMASK(27, 20)) >> 20) & 0x7f) > > It's funny one of them uses style "a" (no GENMASK() use), another > style "b" (GENMASK() is in use). I suggest being consistent: either > drop GENMASK() everywhere, or use them in all suitable places. > Will use GENMASK() everywhere to be consistent. > > > +#define RZG2L_SINGLE_PIN_GET_PORT(x) (((x) >> 24) & 0x7f) > > > +#define RZG2L_SINGLE_PIN_GET_BIT(x) ((((x) & GENMASK(23, 20)) >> 20) & 0x7) > > Ditto. > As mentioned above will use GENMASK() Cheers, Prabhakar
