Re: [PATCH 1/4] dt-bindings: iio: accel: bma255: Add interrupt-names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 19 Jul 2021 13:21:53 +0200
Stephan Gerhold <stephan@xxxxxxxxxxx> wrote:

> The binding already allows specifying both interrupt pins, but there
> is currently no way to describe a board where (for whatever reason)
> only INT2 is connected. Make it possible to use "interrupt-names"
> to make it explicit which interrupt pin is meant in the interrupts.
> 
> Signed-off-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> ---
>  .../devicetree/bindings/iio/accel/bosch,bma255.yaml      | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> index 5b35856b1942..897a1d808ef5 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bma255.yaml
> @@ -49,6 +49,14 @@ properties:
>        the second (optional) interrupt listed must be the one connected to the
>        INT2 pin (if available). The type should be IRQ_TYPE_EDGE_RISING.

Looks like this comment needs updating to say the ordering is only true if
interrupt-names is not present.

Jonathan


>  
> +  interrupt-names:
> +    minItems: 1
> +    maxItems: 2
> +    items:
> +      enum:
> +        - INT1
> +        - INT2
> +
>    mount-matrix:
>      description: an optional 3x3 mounting rotation matrix.
>  
> @@ -73,6 +81,7 @@ examples:
>              vddio-supply = <&vddio>;
>              vdd-supply = <&vdd>;
>              interrupts = <57 IRQ_TYPE_EDGE_RISING>;
> +            interrupt-names = "INT1";
>          };
>      };
>    - |




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux