Hi Fabio, > -----Original Message----- > From: Fabio Estevam <festevam@xxxxxxxxx> > Sent: 2021年7月23日 21:16 > To: Vladimir Oltean <olteanv@xxxxxxxxx> > Cc: David S. Miller <davem@xxxxxxxxxxxxx>; Shawn Guo > <shawnguo@xxxxxxxxxx>; moderated list:ARM/FREESCALE IMX / MXC ARM > ARCHITECTURE <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx>; Joakim Zhang > <qiangqing.zhang@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; netdev > <netdev@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED > DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx> > Subject: Re: [PATCH net-next] ARM: dts: imx6qdl: Remove unnecessary mdio > #address-cells/#size-cells > > Hi Vladimr, > > On Fri, Jul 23, 2021 at 10:08 AM Vladimir Oltean <olteanv@xxxxxxxxx> wrote: > > > Are you actually sure this is the correct fix? If I look at mdio.yaml, > > I think it is pretty clear that the "ethernet-phy" subnode of the MDIO > > controller must have an "@[0-9a-f]+$" pattern, and a "reg" property. > > If it did, then it wouldn't warn about #address-cells. > > Thanks for reviewing it. > > After double-checking I realize that the correct fix would be to pass the phy > address, like: > > phy: ethernet-phy@1 { > reg = <1>; > > Since the Ethernet PHY address is design dependant, I can not make the fix > myself. > > I will try to ping the board maintainers for passing the correct phy address. Thanks. I prepare this patch to fix dtbs_check when convert fec binding into schema. I realized that we need a "reg" under phy device node, but I also don't know how to add it since the phy is obviously not on board. And I check the phy code, it supports auto scan for PHYs with empty "reg" property. Best Regards, Joakim Zhang > Thanks