Hi, Thanks for your review. On Wed, Jul 14, 2021 at 01:21:30PM -0600, Rob Herring wrote: > On Thu, Jun 24, 2021 at 12:43:34PM +0900, Nobuhiro Iwamatsu wrote: > > This adds support for common interface of the common clock and reset driver > > for Toshiba Visconti5 and its SoC, TMPV7708. The PIPLLCT provides the PLL, > > and the PISMU provides clock and reset functionality. > > Each drivers are provided in this patch. > > > > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx> > > --- > > drivers/clk/Makefile | 1 + > > drivers/clk/visconti/Makefile | 5 + > > drivers/clk/visconti/clkc-tmpv770x.c | 246 +++++++++++++ > > drivers/clk/visconti/clkc.c | 220 +++++++++++ > > drivers/clk/visconti/clkc.h | 75 ++++ > > drivers/clk/visconti/pll-tmpv770x.c | 96 +++++ > > drivers/clk/visconti/pll.c | 369 +++++++++++++++++++ > > drivers/clk/visconti/pll.h | 63 ++++ > > drivers/clk/visconti/reset.c | 111 ++++++ > > drivers/clk/visconti/reset.h | 35 ++ > > > include/dt-bindings/clock/toshiba,tmpv770x.h | 181 +++++++++ > > include/dt-bindings/reset/toshiba,tmpv770x.h | 41 +++ > > These belong with the binding. OK, I will include this to DT binding patche from next. > > > 12 files changed, 1443 insertions(+) > > create mode 100644 drivers/clk/visconti/Makefile > > create mode 100644 drivers/clk/visconti/clkc-tmpv770x.c > > create mode 100644 drivers/clk/visconti/clkc.c > > create mode 100644 drivers/clk/visconti/clkc.h > > create mode 100644 drivers/clk/visconti/pll-tmpv770x.c > > create mode 100644 drivers/clk/visconti/pll.c > > create mode 100644 drivers/clk/visconti/pll.h > > create mode 100644 drivers/clk/visconti/reset.c > > create mode 100644 drivers/clk/visconti/reset.h > > create mode 100644 include/dt-bindings/clock/toshiba,tmpv770x.h > > create mode 100644 include/dt-bindings/reset/toshiba,tmpv770x.h > > > diff --git a/include/dt-bindings/clock/toshiba,tmpv770x.h b/include/dt-bindings/clock/toshiba,tmpv770x.h > > new file mode 100644 > > index 000000000000..923b47a11730 > > --- /dev/null > > +++ b/include/dt-bindings/clock/toshiba,tmpv770x.h > > @@ -0,0 +1,181 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > Dual license DT headers please. OK, I will update. Best regards, Nobuhiro
