On Wed, Jul 14, 2021 at 4:01 AM Stefan Riedmüller <S.Riedmueller@xxxxxxxxx> wrote: > > Hi Rob, > > On Tue, 2021-07-13 at 20:19 -0600, Rob Herring wrote: > > On Mon, Jul 12, 2021 at 10:55:34AM +0200, Stefan Riedmueller wrote: > > > Convert mt9p031 sensor bindings to yaml schema. Also update the > > > MAINTAINERS entry. > > > > > > Although input-clock-frequency and pixel-clock-frequency have not been > > > definded as endpoint propierties in the textual bindings, the sensor > > > does parse them from the endpoint. Thus move these properties to the > > > endpoint in the new yaml bindings. > > > > > > Signed-off-by: Stefan Riedmueller <s.riedmueller@xxxxxxxxx> > > > --- > > > .../bindings/media/i2c/aptina,mt9p031.yaml | 75 +++++++++++++++++++ > > > .../devicetree/bindings/media/i2c/mt9p031.txt | 40 ---------- > > > MAINTAINERS | 1 + > > > 3 files changed, 76 insertions(+), 40 deletions(-) > > > create mode 100644 > > > Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > > delete mode 100644 > > > Documentation/devicetree/bindings/media/i2c/mt9p031.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > > b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > > new file mode 100644 > > > index 000000000000..ad9a2db73d86 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9p031.yaml > > > @@ -0,0 +1,75 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/media/i2c/aptina,mt9p031.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Aptina 1/2.5-Inch 5Mp CMOS Digital Image Sensor > > > + > > > +maintainers: > > > + - Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > + > > > +description: | > > > + The Aptina MT9P031 is a 1/2.5-inch CMOS active pixel digital image > > > sensor > > > + with an active array size of 2592H x 1944V. It is programmable through > > > a > > > + simple two-wire serial interface. > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - aptina,mt9p031 > > > + - aptina,mt9p031m > > > + > > > + reg: > > > + description: I2C device address > > > + maxItems: 1 > > > + > > > + reset-gpios: > > > + maxItems: 1 > > > + description: Chip reset GPIO > > > + > > > + port: > > > + $ref: /schemas/graph.yaml#/$defs/port-base > > > + additionalProperties: false > > > + > > > + properties: > > > + endpoint: > > > + $ref: /schemas/media/video-interfaces.yaml# > > > > Doesn't look like you use any properties from video-interfaces.yaml. You > > should just reference graph.yaml#/$defs/endpoint-base instead. > > Thanks for your comment. It made me realize, that I have something wrong. The > driver does use properties from the video interface as it parses the bus > configuration from the endpoint. But I thought these properties were > implicitly used by referencing the video-interfaces schema. Now I assume that > I have to mention them here explicitly. Correct? Yes, because presumably you only support some subset of possible values. Rob
