Hi Prabhakar, On Tue, Jul 13, 2021 at 6:01 PM Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > On Thu, Jul 1, 2021 at 9:21 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Tue, Jun 29, 2021 at 11:03:27PM +0100, Lad Prabhakar wrote: > > > Add binding documentation for Renesas RZ/G2L A/D converter block. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > --- > > > .../bindings/iio/adc/renesas,rzg2l-adc.yaml | 121 ++++++++++++++++++ > > > 1 file changed, 121 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > > new file mode 100644 > > > index 000000000000..db935d6d59eb > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml > > > @@ -0,0 +1,121 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/adc/renesas,rzg2l-adc.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Renesas RZ/G2L ADC > > > + > > > +maintainers: > > > + - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > + > > > +description: | > > > + A/D Converter block is a successive approximation analog-to-digital converter > > > + with a 12-bit accuracy. Up to eight analog input channels can be selected. > > > + Conversions can be performed in single or repeat mode. Result of the ADC is > > > + stored in a 32-bit data register corresponding to each channel. > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > > You can drop oneOf here. > > > Dropping oneOf from here dt_binding_check complains with below report, > Documentation/devicetree/bindings/iio/adc/renesas,rzg2l-adc.yaml: > properties:compatible: [{'items': [{'enum': > ['renesas,r9a07g044-adc']}, {'const': 'renesas,rzg2l-adc'}]}] is not > of type 'object', 'boolean' > from schema $id: http://json-schema.org/draft-07/schema# You forgot to drop the dash in front of the items, right? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
