Hi Prabhakar, On Tue, Jul 13, 2021 at 10:22 AM Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote: > On Tue, Jul 13, 2021 at 9:08 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > On Mon, Jun 14, 2021 at 2:48 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > On Fri, Jun 11, 2021 at 5:21 PM Lad Prabhakar > > > <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote: > > > > Add the below missing properties into GIC node, > > > > - clocks > > > > - clock-names > > > > - power-domains > > > > - resets > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > > Queueing pending on[1]. > > > > > > > [1] https://lore.kernel.org/linux-devicetree/ > > > > 20210609155108.16590-1-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/ > > > > The dependency has been accepted, but this patch needs a respin > > for the changed clocks. > > > Thank you for pointing this out. wrt resets the GIC has two signals > (which I learnt lately when the dependency path was accepted). Earlier > discussion in irc with Sudeep pointed out that there wouldn't be any > use case of having GIC resets in DTSI, so either we drop the resets > property in DT binding doc or correct it. > > Let me know your thoughts on this and how we proceed further. DT Rule #1: DT describes hardware not software policy. And a possible use case: the RT CPU core may want to reset the AP GIC. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds