On Mon, Jul 12, 2021 at 8:43 PM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Sun, Jul 04, 2021 at 02:32:21PM +0530, Jagan Teki wrote: > > Samsing MIPI DSIM bridge can be found on Exynos and NXP's > > i.MX8M Mini and Nano SoC's. > > > > This dt-bindings replaces legacy exynos_dsim.txt. > > > > Used the example node from latest Exynos SoC instead of > > the one used in legacy exynos_dsim.txt. > > > > Add dt-bingings for it. > > typo > > > > > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > --- > > .../display/bridge/samsung,mipi-dsim.yaml | 278 ++++++++++++++++++ > > .../bindings/display/exynos/exynos_dsim.txt | 90 ------ > > MAINTAINERS | 1 + > > 3 files changed, 279 insertions(+), 90 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > delete mode 100644 Documentation/devicetree/bindings/display/exynos/exynos_dsim.txt > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > new file mode 100644 > > index 000000000000..b2970734ffd7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/samsung,mipi-dsim.yaml > > @@ -0,0 +1,278 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/samsung,mipi-dsim.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Samsung MIPI DSIM bridge controller > > + > > +maintainers: > > + - Inki Dae <inki.dae@xxxxxxxxxxx> > > + - Joonyoung Shim <jy0922.shim@xxxxxxxxxxx> > > + - Seung-Woo Kim <sw0312.kim@xxxxxxxxxxx> > > + - Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > + - Andrzej Hajda <a.hajda@xxxxxxxxxxx> > > + - Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > > + > > +description: | > > + Samsung MIPI DSIM bridge controller can be found it on Exynos > > + and i.MX8M Mini and Nano SoC's. > > + > > +properties: > > + compatible: > > + enum: > > + - samsung,exynos3250-mipi-dsi > > + - samsung,exynos4210-mipi-dsi > > + - samsung,exynos5410-mipi-dsi > > + - samsung,exynos5422-mipi-dsi > > + - samsung,exynos5433-mipi-dsi > > What about i.MX compatibles? I have added in the next patch since this is yml conversation for existing .txt bindings. > > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + '#address-cells': > > + const: 1 > > + > > + '#size-cells': > > + const: 0 > > + > > + clocks: > > + minItems: 2 > > + maxItems: 5 > > + > > + clock-names: > > + minItems: 2 > > + maxItems: 5 > > + > > + phys: > > + maxItems: 1 > > + description: phandle to the phy module representing the DPHY > > Drop > > > + > > + phy-names: > > + items: > > + - const: dsim > > + > > + samsung,phy-type: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: phandle to the samsung phy-type > > + > > + power-domains: > > + description: phandle to the associated power domain > > Drop > > > + maxItems: 1 > > + > > + samsung,power-domain: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: phandle to the associated samsung power domain > > + maxItems: 1 > > + > > + vddcore-supply: > > + description: MIPI DSIM Core voltage supply (e.g. 1.1V) > > + > > + vddio-supply: > > + description: MIPI DSIM I/O and PLL voltage supply (e.g. 1.8V) > > + > > + samsung,burst-clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + DSIM high speed burst mode frequency. > > + > > + samsung,esc-clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + DSIM escape mode frequency. > > + > > + samsung,pll-clock-frequency: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: > > + DSIM oscillator clock frequency. > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > If there are no extra endpoint properties, then use > '/schemas/graph.yaml#/properties/port'. Okay. > > > + description: > > + Input port node to receive pixel data from the > > + display controller. Exactly one endpoint must be > > + specified. > > + properties: > > + endpoint@0: > > + $ref: /schemas/graph.yaml#/properties/endpoint > > + description: sub-node describing the input from MIC > > I'd assume i.MX has a different input than MIC? Yes, updated in next patch. Thanks, Jagan.
