Hi, On Thu, Jun 17, 2021 at 7:02 AM Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> wrote: > > Add MT8195 clock dt-bindings, include topckgen, apmixedsys, > infracfg_ao, pericfg_ao and subsystem clocks. > > Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> > --- > include/dt-bindings/clock/mt8195-clk.h | 989 +++++++++++++++++++++++++ > 1 file changed, 989 insertions(+) This is a really long list. I don't think all of them need to be exposed, especially the intermediate ones in TOPCKGEN. In such cases the not-to-be- exposed clock indices could be moved to a header file in the driver directory, or simply left out. The Allwinner/sunxi-ng drivers do the former while the Rockchip drivers do the latter. The Mediatek clock drivers are more similar in structure and design to the Rockchip ones. Regards ChenYu
