On Thu, Jun 17, 2021 at 7:08 AM Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> wrote: > > Add MT8195 mfgcfg clock provider Same thing about the commit log. More context please. > Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> > --- > drivers/clk/mediatek/Kconfig | 6 ++++ > drivers/clk/mediatek/Makefile | 1 + > drivers/clk/mediatek/clk-mt8195-mfg.c | 49 +++++++++++++++++++++++++++ > 3 files changed, 56 insertions(+) > create mode 100644 drivers/clk/mediatek/clk-mt8195-mfg.c > > diff --git a/drivers/clk/mediatek/Kconfig b/drivers/clk/mediatek/Kconfig > index ef7d4b433eee..066c14a89cee 100644 > --- a/drivers/clk/mediatek/Kconfig > +++ b/drivers/clk/mediatek/Kconfig > @@ -624,6 +624,12 @@ config COMMON_CLK_MT8195_IPESYS > help > This driver supports MediaTek MT8195 ipesys clocks. > > +config COMMON_CLK_MT8195_MFGCFG > + bool "Clock driver for MediaTek MT8195 mfgcfg" > + depends on COMMON_CLK_MT8195 > + help > + This driver supports MediaTek MT8195 mfgcfg clocks. > + Same thing about the Kconfig option. I don't think it's necessary to have separate Kconfig options for clock controllers within the same SoC. > config COMMON_CLK_MT8516 > bool "Clock driver for MediaTek MT8516" > depends on ARCH_MEDIATEK || COMPILE_TEST > diff --git a/drivers/clk/mediatek/Makefile b/drivers/clk/mediatek/Makefile > index 991a9be7ac46..9b09e7f640d1 100644 > --- a/drivers/clk/mediatek/Makefile > +++ b/drivers/clk/mediatek/Makefile > @@ -87,5 +87,6 @@ obj-$(CONFIG_COMMON_CLK_MT8195_CAMSYS) += clk-mt8195-cam.o > obj-$(CONFIG_COMMON_CLK_MT8195_CCUSYS) += clk-mt8195-ccu.o > obj-$(CONFIG_COMMON_CLK_MT8195_IMGSYS) += clk-mt8195-img.o > obj-$(CONFIG_COMMON_CLK_MT8195_IPESYS) += clk-mt8195-ipe.o > +obj-$(CONFIG_COMMON_CLK_MT8195_MFGCFG) += clk-mt8195-mfg.o > obj-$(CONFIG_COMMON_CLK_MT8516) += clk-mt8516.o > obj-$(CONFIG_COMMON_CLK_MT8516_AUDSYS) += clk-mt8516-aud.o > diff --git a/drivers/clk/mediatek/clk-mt8195-mfg.c b/drivers/clk/mediatek/clk-mt8195-mfg.c > new file mode 100644 > index 000000000000..a9b1d337cd01 > --- /dev/null > +++ b/drivers/clk/mediatek/clk-mt8195-mfg.c Code looks good. ChenYu
