Hi Martin, On Thu, 8 Jul 2021 15:09:30 +0200 Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > Hi Viktor, > > On Wed, Jul 7, 2021 at 4:13 PM Viktor Prutyanov > <viktor.prutyanov@xxxxxxxxxxxx> wrote: > > > > This patch adds binding documentation for the IR transmitter > > available in Amlogic Meson SoCs. > > > > Signed-off-by: Viktor Prutyanov <viktor.prutyanov@xxxxxxxxxxxx> > > --- > > changes in v2: > > - compatible = "amlogic,meson-g12a-irblaster" added > > - clocks, clock-names and mod-clock updated > thanks for updating this patch with my feedback! > > [...] > > + mod-clock: > > + maxItems: 1 > in the change-log for this patch you mentioned that mod-clock is > updated as well I think that mod-clock (as a whole property) should > only be added if it's an external input to the IR blaster IP block There are 2 clocks connected to blaster module, and mod-clock is just a selector between them. Meson IR blaster driver should choose one of the modulation clocks. If not through a property, then how to do it? > > > Best regards, > Martin Best regards, Viktor
