Hi Alistair, On Thu, Jul 8, 2021 at 6:16 AM Alistair Francis <alistair23@xxxxxxxxx> wrote: > I'm not sure I follow, we do the same thing here with: > > &clks { > assigned-clocks = <&clks IMX7D_CLKO2_ROOT_SRC>, > <&clks IMX7D_CLKO2_ROOT_DIV>; > assigned-clock-parents = <&clks IMX7D_CKIL>; > assigned-clock-rates = <0>, <32768>; > }; Ah, got it. This was not in the patch context, so that's why I got confused. Now I see it as part of the original file, so it looks good to me, thanks: Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>