Hello Ahmad,
On Wed, Jul 07, 2021 at 01:06:19PM +0200, Ahmad Fatoum wrote:
> On 07.07.21 12:53, Uwe Kleine-König wrote:
> > The nodes after the root nodes are supposed to be ordered
> > alphabetically. So move &flexcan1, &flexcan2 and &pinctrl to their
> > proper place.
>
> At least for i.MX, it seems to be convention to have iomuxc at the end
> of the file.
Oh, that's news to me. Looking at next/master and the output of
$ for f in $(git grep -l \&iomux arch/arm/boot/dts/imx* arch/arm64/boot/dts/freescale/*); do awk '/^&/ { handle = $1; } END { if ( handle == "&iomuxc" ) { print "end" } else { print "middle" } }' "$f"; done | sort | uniq -c
158 end
143 middle
(i.e. among the files that have a &iomux node, iomuxc is at the end for
158, and for 143 is isn't)
So that convention is either new or not very binding.
Note: In the end case there are a few (e.g.
arch/arm/boot/dts/imx6qdl-pico-dwarf.dtsi and
arch/arm/boot/dts/imx6qdl-pico-pi.dtsi) where iomuxc is at the end and
the file is sorted.
> I'd not reorder it, file is easier to browse when it's not in the
> middle.
Seems to be subjective :-)
I would consider it easier to browse if each pinmux define would be near
the device node that makes use of it, but iomuxc being at the end
doesn't have an advantage for me.
I don't feel like resending to only fix the flexcan ordering.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
