On Thu, Jun 17, 2021 at 7:08 AM Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> wrote: > > Add MT8195 ipesys clock provider It would be better if you could provide some more context for the patch, such as what hardware subsystem / group does this belong to, what do these clocks feed into? And in the case of supporting multiple clock controllers in one driver, what led you to group them in the same driver? This applies to all your patches. The single statement "Add xxx clock provider" is simply repeating what the subject already says. The code looks OK. Thanks ChenYu > Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx>