On Wed, Jun 30, 2021 at 3:56 PM kyrie.wu <kyrie.wu@xxxxxxxxxxxx> wrote: > Mt8195 has two hardwares, "mediatek,mt8195-jpgenc0" for hw0 and > "mediatek,mt8195-jpgenc1" for HW1. These two nodes will register > hardware interrupt, initialize clock, power domain, remap register base > addr and other operations. But the device node is not registered. > "mediatek,mt8195-jpgenc" will register the device node to represent jpeg > encode device. Then the component framework is used to manage the above > two hardwares. Please don't top-posting. Inline your replies so that people can easily follow the discussion. I still don't quite understand why it needs to introduce 2 compatible strings. If hw0 and hw1 are different from interrupts, clocks, power domain, and etc, couldn't you use the same compatible string (e.g. "mt8195-jpgenc") and provide them different DT attributes? > On Fri, 2021-06-25 at 17:18 +0800, Tzung-Bi Shih wrote: > > On Wed, Jun 23, 2021 at 2:06 PM kyrie.wu <kyrie.wu@xxxxxxxxxxxx> wrote: > > > Documentation/devicetree/bindings/media/mediatek-jpeg-encoder.txt | 3 +++ > > > 1 file changed, 3 insertions(+) > > Note: the patch won't apply after [1]. > > > > [1]: https://lore.kernel.org/patchwork/patch/1445298/ > > > > > Required properties: > > > - compatible : "mediatek,mt2701-jpgenc" > > > +- compatible : "mediatek,mt8195-jpgenc" > > > +- compatible : "mediatek,mt8195-jpgenc0" > > > +- compatible : "mediatek,mt8195-jpgenc1" > > Why it needs 3 compatible strings?
