Hi Sean,
On Thu, Jul 1, 2021 at 8:20 PM Sean Anderson <sean.anderson@xxxxxxxx> wrote:
> These properties allow configuring the SD/OE pin as described in the
> datasheet.
>
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> ---
>
> Changes in v4:
> - Specify that bindings should specify these properties, but don't make
> any guarantees about the driver's behavior when they are not present.
> - Clarify description of idt,(en|dis)able-shutdown properties.
> - Make opposing properties mutually exclusive.
> - Add these properties to the example.
Thanks for the update!
> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
> @@ -109,6 +152,22 @@ allOf:
> required:
> - clock-names
> - clocks
> + - if:
> + true
> + then:
> + oneOf:
> + - required:
> + - idt,enable-shutdown
> + - required:
> + - idt,disable-shutdown
> + - if:
> + true
> + then:
> + oneOf:
> + - required:
> + - idt,output-enable-active-high
> + - required:
> + - idt,output-enable-active-low
Do you really need the "if: true then:"?
Just the "oneOf: ..." worked fine for me in another binding, but then I
didn't have a surrounding "allOf" to interfere...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
