On Thu, Jul 01, 2021 at 08:02:43AM -0600, Rob Herring wrote: > On Sun, 27 Jun 2021 17:32:34 +0100, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > > > Binding is a little stricter than the Linux driver. > > > > It requires vcc-supply to be present for devices that don't have > > an internal reference, whereas the driver just prints a message and > > carries on. Given this means that it is impossible to establish > > a scaling of the output channel, let us make it required in the binding > > schema. > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx> > > Cc: Lars-Peter Clausen <lars@xxxxxxxxxx> > > --- > > .../bindings/iio/dac/adi,ad5446.yaml | 105 ++++++++++++++++++ > > 1 file changed, 105 insertions(+) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/ti,dac7512.example.dt.yaml: dac@0: 'vcc-supply' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/iio/dac/adi,ad5446.yaml Humm, seems it's not missing? Rob
