On 01/07/2021 04:13, Chun-Jie Chen wrote: > On Wed, 2021-06-30 at 22:30 +0800, Chun-Kuang Hu wrote: >> Hi, Chun-Jie: >> >> Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> 於 2021年6月30日 週三 下午9:30寫道: >>> >>> This patch adds the new binding documentation for system clock >>> and functional clock on Mediatek MT8192. >>> >>> Signed-off-by: Chun-Jie Chen <chun-jie.chen@xxxxxxxxxxxx> >>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >>> --- >> >> [snip] >> >>> + >>> + - | >>> + mmsys: clock-controller@14000000 { >> >> mmsys is a system controller rather than clock controller, isn't it? >> >> Regards, >> Chun-Kuang. >> >>> + compatible = "mediatek,mt8192-mmsys"; >>> + reg = <0x14000000 0x1000>; >>> + #clock-cells = <1>; >>> + }; >>> + > > Thanks for you reminder, I will move mmsys to system clock controller. > The mmsys should be documented in mediatek,mmsys.txt Regards, Matthias