On Wed, 30 Jun 2021 at 15:31, Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On sm8250 dispcc requires MMCX power domain to be powered up before > clock controller's registers become available. For now sm8250 was using > external regulator driven by the power domain to describe this > relationship. Switch into specifying power-domain and required opp-state > directly. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > --- > .../bindings/clock/qcom,dispcc-sm8x50.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > index 0cdf53f41f84..48d86fb34fa7 100644 > --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml > @@ -55,6 +55,16 @@ properties: > reg: > maxItems: 1 > > + power-domains: > + description: > + A phandle and PM domain specifier for the MMCX power domain. > + maxItems: 1 > + Should you perhaps state that this is a parent domain? Or it isn't? Related to this and because this is a power domain provider, you should probably reference the common power-domain bindings somewhere here. Along the lines of this: - $ref: power-domain.yaml# As an example, you could have a look at Documentation/devicetree/bindings/power/pd-samsung.yaml. > + required-opps: > + description: > + Performance state to use for MMCX to enable register access. > + maxItems: 1 According to the previous discussions, I was under the assumption that this property belongs to a consumer node rather than in the provider node, no? > + > required: > - compatible > - reg > @@ -64,6 +74,15 @@ required: > - '#reset-cells' > - '#power-domain-cells' > > +# Either both properties are present or both are absent > +dependencies: > + power-domains: > + required: > + - required-opps > + required-opps: > + required: > + - power-domains > + > additionalProperties: false > > examples: > -- > 2.30.2 > Kind regards Uffe
